tirkarthi commented on code in PR #45215:
URL: https://github.com/apache/airflow/pull/45215#discussion_r1897823807
##########
airflow/ui/src/pages/Run/TaskInstances.tsx:
##########
@@ -101,13 +180,59 @@ export const TaskInstances = () => {
limit: pagination.pageSize,
offset: pagination.pageIndex * pagination.pageSize,
orderBy,
+ state: filteredState === null ? undefined : [filteredState],
+ taskDisplayNamePattern: Boolean(taskDisplayNamePattern)
+ ? taskDisplayNamePattern
+ : undefined,
},
undefined,
{ enabled: !isNaN(pagination.pageSize) },
);
return (
- <Box>
+ <Box pt={4}>
+ <HStack>
+ <Select.Root
+ collection={stateOptions}
+ maxW="250px"
+ onValueChange={handleStateChange}
+ value={[filteredState ?? "all"]}
+ >
+ <Select.Trigger colorPalette="blue"
isActive={Boolean(filteredState)}>
+ <Select.ValueText>
+ {() =>
+ filteredState === null ? (
Review Comment:
The pattern is used in the new UI code and is in fact from the runs list tab
for dag page. Using only `filteredState ?` results in below lint error.
```
/home/karthikeyan/stuff/python/airflow/airflow/ui/src/pages/Run/TaskInstances.tsx
204:19 error Unexpected nullable string value in conditional. Please
handle the nullish/empty cases explicitly
@typescript-eslint/strict-boolean-expressions
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
