pierrejeambrun commented on code in PR #45215:
URL: https://github.com/apache/airflow/pull/45215#discussion_r1905681035
##########
airflow/ui/src/components/SearchBar.tsx:
##########
@@ -61,9 +69,11 @@ export const SearchBar = ({ buttonProps, defaultValue,
groupProps, onChange, pla
size="xs"
/>
) : undefined}
- <Button fontWeight="normal" height="1.75rem" variant="ghost"
width={140} {...buttonProps}>
- Advanced Search
- </Button>
+ {Boolean(hideAdvanced) ? undefined : (
+ <Button fontWeight="normal" height="1.75rem" variant="ghost"
width={140} {...buttonProps}>
+ Advanced Search
+ </Button>
+ )}
Review Comment:
I am not aware of a SearchBar that actually leverage this feature. (with a
working button).
As you mentioned in the description. This can be removed if unused.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
