ashb commented on PR #45106: URL: https://github.com/apache/airflow/pull/45106#issuecomment-2563662725
This still doesn't feel right to me @amoghrajesh -- I think "should_fail" as a property on the task state, and all the plumbing we need to set through the layers is a sign that the design isn't right yet. Spit-balling here, but what if we had a different state, so instead of sending `TerminalTIState.FAILED` we sent `TerminalTIState.FAIL_WITHOUT_RETRY` or something. By doing that it would mean we wouldn't need a new object process<->supervisor comms, nor `_fail_request_sent` as that would be handled by the existing terminal state mechanism -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
