kaxil commented on code in PR #45106:
URL: https://github.com/apache/airflow/pull/45106#discussion_r1898673551
##########
task_sdk/tests/execution_time/test_supervisor.py:
##########
@@ -884,6 +884,18 @@ def watched_subprocess(self, mocker):
"",
id="patch_task_instance_to_skipped",
),
+ # testing to see if supervisor can handle TaskState message with
state as fail_with_retry
+ pytest.param(
+ TaskState(
+ state=TerminalTIState.FAIL_WITHOUT_RETRY,
+ end_date=timezone.parse("2024-10-31T12:00:00Z"),
+ ),
+ b"",
+ "",
+ (),
+ "",
+ id="patch_task_instance_to_failed_with_retries",
+ ),
Review Comment:
imo this test does not add anything or test anything new.
We already check `TaskState` as part of SKIPPED, and since we don't need to
assert all the states that are supported by `TaskState`
##########
task_sdk/tests/execution_time/test_supervisor.py:
##########
@@ -884,6 +884,18 @@ def watched_subprocess(self, mocker):
"",
id="patch_task_instance_to_skipped",
),
+ # testing to see if supervisor can handle TaskState message with
state as fail_with_retry
+ pytest.param(
+ TaskState(
+ state=TerminalTIState.FAIL_WITHOUT_RETRY,
+ end_date=timezone.parse("2024-10-31T12:00:00Z"),
+ ),
+ b"",
+ "",
+ (),
+ "",
+ id="patch_task_instance_to_failed_with_retries",
+ ),
Review Comment:
We should remove it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
