amoghrajesh commented on code in PR #45106:
URL: https://github.com/apache/airflow/pull/45106#discussion_r1899336234
##########
task_sdk/tests/execution_time/test_supervisor.py:
##########
@@ -884,6 +884,18 @@ def watched_subprocess(self, mocker):
"",
id="patch_task_instance_to_skipped",
),
+ # testing to see if supervisor can handle TaskState message with
state as fail_with_retry
+ pytest.param(
+ TaskState(
+ state=TerminalTIState.FAIL_WITHOUT_RETRY,
+ end_date=timezone.parse("2024-10-31T12:00:00Z"),
+ ),
+ b"",
+ "",
+ (),
+ "",
+ id="patch_task_instance_to_failed_with_retries",
+ ),
Review Comment:
Yeah, we do not need it, the message type is enough, this was a carry over
from when i called it "FailState". Will remove
##########
task_sdk/tests/execution_time/test_supervisor.py:
##########
@@ -916,6 +929,9 @@ def test_handle_requests(
4. Verifies that the response is correctly decoded.
"""
+ instant = tz.datetime(2024, 11, 7, 12, 0, 0, 0)
+ time_machine.move_to(instant, tick=False)
Review Comment:
WRT https://github.com/apache/airflow/pull/45106#discussion_r1898673551,
will remove this part
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
