hardeybisey commented on PR #45264: URL: https://github.com/apache/airflow/pull/45264#issuecomment-2571263496
> Thanks for the contribution! I always wanted to make this but the big shift to Airflow 3 distracted me from making this... > > Once check that we need to discuss on attribute model... > > ... and besides this, would it make sense to consider adding UI changes in the same PR as well? Else the group display name would have no effect other than just adding an attribute. Thank you for taking the time to review this and for your thoughtful feedback! To clarify, when you mention the display name having no effect, are you suggesting it doesn’t currently reflect in the UI? In this implementation, when the group display name is provided, it is displayed in the UI as expected as shown below. <img width="785" alt="image" src="https://github.com/user-attachments/assets/74c3f528-4965-4cd3-8bb0-d3cf2d411ca8"; /> Regarding the UI changes, I’d be happy to extend this PR to also include a new Group Display Name key as part of the task group details on this page if that is what you are suggesting. <img width="840" alt="image" src="https://github.com/user-attachments/assets/2372e01a-7d6b-4449-b782-1853753965bb"; /> Please let me know the direction you’d like me to proceed. Thank you! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
