Re: [PR] Add `group_display_name` attribute to allow specifying a custom display name in the UI for TaskGroup [airflow]

Sat, 04 Jan 2025 06:46:34 -0800 


hardeybisey commented on PR #45264:
URL: https://github.com/apache/airflow/pull/45264#issuecomment-2571323704

   > > > Thanks for the contribution! I always wanted to make this but the big 
shift to Airflow 3 distracted me from making this...
   > > > Once check that we need to discuss on attribute model...
   > > > ... and besides this, would it make sense to consider adding UI 
changes in the same PR as well? Else the group display name would have no 
effect other than just adding an attribute.
   > > 
   > > 
   > > Thank you for taking the time to review this and for your thoughtful 
feedback!
   > > To clarify, when you mention the display name having no effect, are you 
suggesting it doesn’t currently reflect in the UI? In this implementation, when 
the group display name is provided, it is displayed in the UI as expected as 
shown below.
   > > <img alt="image" width="1018" 
src="https://private-user-images.githubusercontent.com/104902482/400136461-137b9d4b-e8c7-4f5f-af3a-c76638036ad1.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MzU5OTc4ODEsIm5iZiI6MTczNTk5NzU4MSwicGF0aCI6Ii8xMDQ5MDI0ODIvNDAwMTM2NDYxLTEzN2I5ZDRiLWU4YzctNGY1Zi1hZjNhLWM3NjYzODAzNmFkMS5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjUwMTA0JTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI1MDEwNFQxMzMzMDFaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT05ZmVjNWZjN2Y5NDlkZDA0ODIyYmM2ZmIzYjMzOTVhZjRmNzg2ZjQyMWNkZWExODU5YTUzOGUyYWE0OWFkYmM3JlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCJ9.2yVDKByjc3ZS0nUGb1objoQ0ZireZ3jfkHq254u3yi0";>
   > > Regarding the UI changes, I’d be happy to extend this PR to also include 
a new Group Display Name key as part of the task group details on this page if 
that is what you are suggesting. <img alt="image" width="840" 
src="https://private-user-images.githubusercontent.com/104902482/400136149-2372e01a-7d6b-4449-b782-1853753965bb.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MzU5OTc4ODEsIm5iZiI6MTczNTk5NzU4MSwicGF0aCI6Ii8xMDQ5MDI0ODIvNDAwMTM2MTQ5LTIzNzJlMDFhLTdkNmItNDQ0OS1iNzgyLTE4NTM3NTM5NjViYi5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjUwMTA0JTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI1MDEwNFQxMzMzMDFaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT0wOGE0ZWJkOWFiMzk5MTM2NGEzYjJmYWE0YWI3ZDEzYTk3NTViOGZjMDk5MTc4MDAzMTU0NGY3MDJmMTUwMDZjJlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCJ9.CWqrbEQTc-s7083D8RZYn_nXnMwbfNuGG
 Lh3AvdCaJQ">
   > > Please let me know the direction you’d like me to proceed. Thank you!
   > 
   > Oh, did not notice that UI changed w/o touching the code. Cool. I assume 
on current (legacy) UI no changes are needed. But if you like... the "new" UI 
is under construction and if you want to contribute there... any contribution 
is welcome! https://github.com/orgs/apache/projects/400
   
   Thanks for the feedback! Just to confirm, does this mean the PR is ready to 
go and meets the current requirements?
   
   Also, I’m happy to contribute to other areas that are not UI-related, as I’m 
not an expert with frontend libraries or code :smile: 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to