potiuk commented on code in PR #45408:
URL: https://github.com/apache/airflow/pull/45408#discussion_r1903270537


##########
.github/workflows/ci.yml:
##########
@@ -39,7 +39,6 @@ permissions:
   # denied error when attempting to just pull private image, changing the 
token permission to write solves the
   # issue. This is not dangerous, because if it is for "apache/airflow", only 
maintainers can push ci.yml
   # changes. If it is for a fork, then the token is read-only anyway.
-  packages: write

Review Comment:
   We should also remove the comment above. I think we do not need it all any 
more when private repos are used to build images with the new scheme- because 
we are using artifacts and not github registry to share images.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to