potiuk commented on code in PR #45408:
URL: https://github.com/apache/airflow/pull/45408#discussion_r1903272016
##########
.github/workflows/release_dockerhub_image.yml:
##########
@@ -146,53 +149,74 @@ jobs:
# from the source code, not from the PyPI because they have
apache-airflow>=X.Y.Z dependency
# And when we prepare them from sources they will have
apache-airflow>=X.Y.Z.dev0
shell: bash
+ env:
+ CHICKEN_EGG_PROVIDERS: ${{
needs.build-info.outputs.chicken-egg-providers }}
run: >
breeze release-management prepare-provider-packages
--package-format wheel
- --version-suffix-for-pypi dev0 ${{
needs.build-info.outputs.chicken-egg-providers }}
+ --version-suffix-for-pypi dev0 ${CHICKEN_EGG_PROVIDERS}
if: needs.build-info.outputs.chicken-egg-providers != ''
- name: "Copy dist packages to docker-context files"
shell: bash
run: cp -v --no-preserve=mode,ownership ./dist/*.whl
./docker-context-files
if: needs.build-info.outputs.chicken-egg-providers != ''
- name: >
Release regular images: ${{ github.event.inputs.airflowVersion }},
${{ matrix.python-version }}
- run: >
- breeze release-management release-prod-images
- --dockerhub-repo ${{ github.repository }}
- --airflow-version ${{ github.event.inputs.airflowVersion }}
- ${{ needs.build-info.outputs.skipLatest }}
- ${{ needs.build-info.outputs.limitPlatform }}
- --limit-python ${{ matrix.python-version }}
- --chicken-egg-providers "${{
needs.build-info.outputs.chicken-egg-providers }}"
env:
COMMIT_SHA: ${{ github.sha }}
- - name: >
- Release slim images: ${{ github.event.inputs.airflowVersion }}, ${{
matrix.python-version }}
+ REPOSITORY: ${{ github.repository }}
+ PYTHON_VERSION: ${{ matrix.python-version }}
+ AIRFLOW_VERSION: ${{ github.event.inputs.airflowVersion }}
+ SKIP_LATEST: ${{ needs.build-info.outputs.skipLatest }}
+ LIMIT_PLATFORM: ${{ needs.build-info.outputs.limitPlatform }}
+ CHICKEN_EGG_PROVIDERS: ${{
needs.build-info.outputs.chicken-egg-providers }}
run: >
breeze release-management release-prod-images
- --dockerhub-repo ${{ github.repository }}
- --airflow-version ${{ github.event.inputs.airflowVersion }}
- ${{ needs.build-info.outputs.skipLatest }}
- ${{ needs.build-info.outputs.limitPlatform }}
- --limit-python ${{ matrix.python-version }} --slim-images
+ --dockerhub-repo ${REPOSITORY}
Review Comment:
Here on the other hand we could add quotes :).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]