potiuk commented on code in PR #45408:
URL: https://github.com/apache/airflow/pull/45408#discussion_r1903273047


##########
.github/workflows/ci.yml:
##########
@@ -39,7 +39,6 @@ permissions:
   # denied error when attempting to just pull private image, changing the 
token permission to write solves the
   # issue. This is not dangerous, because if it is for "apache/airflow", only 
maintainers can push ci.yml
   # changes. If it is for a fork, then the token is read-only anyway.
-  packages: write

Review Comment:
   just set `packages: write` in those jobs that do  `push-buildx-cache` - but 
you have to add `packages: write` in the particular jobs that call composite 
workflows not in the workflows themselves - you cannot elevate permissions 
inside the composite workflow, you can also set the permission in the parent 
workflow - and you can do it at the level of individual jobs in the parent 
workflow, it does not have to be set for the whole workflow.
   
   
   
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to