tssahota commented on code in PR #45025:
URL: https://github.com/apache/airflow/pull/45025#discussion_r1905266412
##########
providers/src/airflow/providers/amazon/aws/transfers/dynamodb_to_s3.py:
##########
@@ -166,15 +166,14 @@ def execute(self, context: Context) -> None:
# function. This change introduces a new boolean, as the indicator for
whether the operator scans
# and export entire data or using the point in time functionality.
if self.point_in_time_export or self.export_time:
- self._export_table_to_point_in_time()
- else:
- self._export_entire_data()
+ return self._export_table_to_point_in_time()
+ return self._export_entire_data()
Review Comment:
Hi @eladkal, sorry for the delay, first time contributer, I assume you mean
to remove the else and return the _export_entire_data() function when if
condition is False.
Please let me know if there's a better alternative.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
