jason810496 commented on code in PR #45393: URL: https://github.com/apache/airflow/pull/45393#discussion_r1907232563
########## airflow/api_fastapi/core_api/routes/public/dag_report.py: ########## @@ -0,0 +1,49 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +from __future__ import annotations + +from airflow.api_fastapi.common.router import AirflowRouter +from airflow.api_fastapi.core_api.datamodels.dag_report import ( + DagReportCollectionResponse, + DagReportResponse, +) +from airflow.models.dagbag import DagBag +from airflow.utils.cli import process_subdir + +dag_report_router = AirflowRouter(tags=["DagReport"], prefix="/dagReport") + + +@dag_report_router.get( + "", +) +def get_dag_report( + subdir: str, Review Comment: Hi @pierrejeambrun , I agree with reusing `request.app.state.dag_bag` instead of creating a new `DagBag` instance at the router each time. I just tried retrieving `dagbag_stats` from `request.app.state.dag_bag` and found that the `DagBag` for the REST API is constructed with `read_dags_from_db=True`. https://github.com/apache/airflow/blob/main/airflow/www/extensions/init_dagbag.py#L29 This means the only way to get a list of DAGs is by calling `collect_dags_from_db`. https://github.com/apache/airflow/blob/main/airflow/models/dagbag.py#L596-L605 Additionally, for the `dagbag_stats` information required by this API — such as `file_parse_duration`, `dag_num`, `task_num`, and `warning_num`— these details aren't available in `SerializedDagModel`. It seems this would require more effort to sync these additional `dagbag_stats` details from the filesystem to the database. This would involve adding more fields to `SerializedDagModel` and implementing the corresponding sync logic in `DagBag`. Is there an alternative solution to retrieve these `dagbag_stats` from the database instead of the filesystem ? Or would implementing this logic for the feature be considered acceptable ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
