jason810496 commented on code in PR #45393: URL: https://github.com/apache/airflow/pull/45393#discussion_r1923951444
########## airflow/api_fastapi/core_api/routes/public/dag_report.py: ########## @@ -0,0 +1,56 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +from __future__ import annotations + +import os +from typing import cast + +from fastapi import HTTPException, status + +from airflow import settings +from airflow.api_fastapi.common.router import AirflowRouter +from airflow.api_fastapi.core_api.datamodels.dag_report import ( + DagReportCollectionResponse, + DagReportResponse, +) +from airflow.api_fastapi.core_api.openapi.exceptions import create_openapi_http_exception_doc +from airflow.models.dagbag import DagBag + +dag_report_router = AirflowRouter(tags=["DagReport"], prefix="/dagReports") + + +@dag_report_router.get( + "", + responses=create_openapi_http_exception_doc( + [ + status.HTTP_400_BAD_REQUEST, + ] + ), +) +def get_dag_report( + subdir: str, +): + """Get DAG report.""" + fullpath = os.path.normpath(subdir) + if not fullpath.startswith(settings.DAGS_FOLDER): + raise HTTPException(status.HTTP_400_BAD_REQUEST, "subdir should be subpath of DAGS_FOLDER settings") + dagbag = DagBag(subdir) Review Comment: Thanks, @pierrejeambrun! I overlooked this typo and couldn't figure out why the CI was still failing this morning! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
