bbovenzi opened a new pull request, #45987: URL: https://github.com/apache/airflow/pull/45987
There were a number of issues with clearing a run or task: - we were calling PATCH run/task to update the note even if the note didnt change - we were calling dry run when the button mounted even if the modal was never opened, which on the table of task instances could be 25 different API calls - we weren't caching any of the dry_runs so we needed a new request any time the user toggled any options Solution: - check if the note has changed before adding that mutation - Make custom hooks to turn the dry run mutations into queries which we can cache - Pass `enabled: open` to the dry run queries to cache results - Removed `useEffect` which is usually a bad practice --- **^ Add meaningful description above** Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)** for more information. In case of fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals)) is needed. In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x). In case of backwards incompatible changes please leave a note in a newsfragment file, named `{pr_number}.significant.rst` or `{issue_number}.significant.rst`, in [newsfragments](https://github.com/apache/airflow/tree/main/newsfragments). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
