pierrejeambrun commented on code in PR #45987:
URL: https://github.com/apache/airflow/pull/45987#discussion_r1928361637
##########
airflow/ui/src/components/Clear/ClearAccordion.tsx:
##########
@@ -35,7 +35,7 @@ type Props = {
// Table is in memory, pagination and sorting are disabled.
// TODO: Make a front-end only unconnected table component with client side
ordering and pagination
const ClearAccordion = ({ affectedTasks, note, setNote }: Props) => (
- <Accordion.Root collapsible defaultValue={["note"]} multiple={false}
variant="enclosed">
+ <Accordion.Root collapsible defaultValue={["tasks"]} multiple={false}
variant="enclosed">
Review Comment:
That was the default behavior but Jens explicitly asked to show the `note`
as default to encourage the usage of notes going forward. I'm neutral on what
should be the default. (tasks feels more natural, but encouraging usage of
notes, is not bad too).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
