rawwar commented on code in PR #44306:
URL: https://github.com/apache/airflow/pull/44306#discussion_r1928013466
##########
airflow/api_fastapi/core_api/datamodels/plugins.py:
##########
@@ -75,6 +75,9 @@ class PluginResponse(BaseModel):
ti_deps: list[Annotated[str, BeforeValidator(coerce_to_string)]]
listeners: list[str]
timetables: list[str]
+ priority_weight_strategies: list[Any]
+ admin_views: list[Any]
+ menu_links: list[Any]
Review Comment:
> allow extra for XXXXResponse and only apply it to XXXXBody
For this, I think, we need to extend BaseModel to have ResponseBaseModel and
RequestBaseModel. Does that sound ok?
##########
airflow/api_fastapi/core_api/datamodels/plugins.py:
##########
@@ -75,6 +75,9 @@ class PluginResponse(BaseModel):
ti_deps: list[Annotated[str, BeforeValidator(coerce_to_string)]]
listeners: list[str]
timetables: list[str]
+ priority_weight_strategies: list[Any]
+ admin_views: list[Any]
+ menu_links: list[Any]
Review Comment:
> allow extra for XXXXResponse and only apply it to XXXXBody
For this, I think, we need to extend BaseModel to have ResponseBaseModel and
RequestBaseModel. Does that sound ok?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
