pierrejeambrun commented on PR #44306: URL: https://github.com/apache/airflow/pull/44306#issuecomment-2615100949
> Also, Do we even need to have this specific check? ConnectionBody(**patch_body.model_dump()) feels redundant, given input is already validated during request. The idea behind this check is to ensure that the given payload is a fully formed entity before moving further and saving that to the DB. Why we do that is because the endpoint can accept partial updates, when we give a partial `PathBody` with a lot of None field and without specifying an update mask, we verify that this payload can be saved to the db. I would say that we need to keep that, but we still need to figure out the other problem that you are mentioning. `extra_forbidden` and `aliases` should play nicely together. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
