pierrejeambrun commented on PR #46018: URL: https://github.com/apache/airflow/pull/46018#issuecomment-2613100643
> What if we made this a GET endpoint? Since its a dry_run, we're not actually changing anything and then it saves us the time of building a custom query wrapper like I just did for clearing in https://github.com/apache/airflow/pull/45987. We could do that to save an extra custom query wrapper in the front-end. We also have the create backfill endpoint that currently implements a `dry_run` version as well. If we are to put `dry_run` versions of endpoints on `GET` method, we most likely need to rework that create backfill dry_run endpoint to comply with that. Also we need to convert payloads used for the non dry_run version of POST / PATCH into query parameters and perform the same validation most likely instantiating back those data models. I think the work we save on the front-end is balanced out by the extra work we need on the backend. (though all of that are minor efforts) Also that's just me but as a user I wouldn't expect the method to change from a dry_run call to a non dry_run one. I would lean towards keeping the same method when implementing a dry_run version of an endpoint. Considering the elements above, let me know if that makes sense 😄 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
