vincbeck commented on PR #45986:
URL: https://github.com/apache/airflow/pull/45986#issuecomment-2616140580

   > > Unrelated to this PR but, ideally we'll want to update the `def 
get_user` from the simple auth manager I think.
   > > Currently is uses the flask `session` object so we cannot use it in the 
flask context. We have to manually use the `core_api/security.py` `get_user` 
function that retrieve the user from the token instead, which is working but 
being able to use the auth_manager interface is maybe more convenient ?
   > 
   > The method `get_user` from the auth manager will be deleted. This is only 
used in AF2. We could, as you mentioned and similar to the function 
`get_jwt_token` in the auth manager interface, create a function 
`get_user_from_token` (or any other name) which basically does what the 
`get_user` in `core_api/security.py` does. It will be a thin wrapper around 
`deserialize_user`. I'll create a PR for it
   
   #46135


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to