o-nikolas commented on code in PR #45859:
URL: https://github.com/apache/airflow/pull/45859#discussion_r1931090017
##########
providers/src/airflow/providers/standard/triggers/file.py:
##########
@@ -69,9 +69,11 @@ async def run(self) -> typing.AsyncIterator[TriggerEvent]:
mod_time =
datetime.datetime.fromtimestamp(mod_time_f).strftime("%Y%m%d%H%M%S")
self.log.info("Found File %s last modified: %s", path,
mod_time)
yield TriggerEvent(True)
+ await asyncio.sleep(self.poke_interval)
Review Comment:
It might be worth testing to be sure, but I'd also expect the triggerer to
move on to another trigger while waiting for this sleep. Otherwise, the poke
sleeps themselves would block the triggerer massively.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
