o-nikolas commented on code in PR #45859:
URL: https://github.com/apache/airflow/pull/45859#discussion_r1931128362
##########
providers/src/airflow/providers/standard/triggers/file.py:
##########
@@ -69,9 +69,11 @@ async def run(self) -> typing.AsyncIterator[TriggerEvent]:
mod_time =
datetime.datetime.fromtimestamp(mod_time_f).strftime("%Y%m%d%H%M%S")
self.log.info("Found File %s last modified: %s", path,
mod_time)
yield TriggerEvent(True)
+ await asyncio.sleep(self.poke_interval)
return
for _, _, files in os.walk(self.filepath):
if files:
yield TriggerEvent(True)
+ await asyncio.sleep(self.poke_interval)
return
await asyncio.sleep(self.poke_interval)
Review Comment:
> Instead of modifying the triggers to handle that, why do not we update the
logic in the triggerer to add a sleeping window between 2 fires of the same
trigger (that would be applied to only triggers used for event driven
scheduling). WDYT?
So you're proposing to close this PR and open a more generic one to solve
the edge case more generally? If so I like that plan :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
