amoghrajesh commented on code in PR #46375:
URL: https://github.com/apache/airflow/pull/46375#discussion_r1942299682
##########
tests/models/test_renderedtifields.py:
##########
@@ -368,30 +369,36 @@ def test_write(self, dag_maker):
)
@mock.patch.dict(os.environ, {"AIRFLOW_VAR_API_KEY": "secret"})
- @mock.patch("airflow.utils.log.secrets_masker.redact", autospec=True)
Review Comment:
That would require me to import `AIRFLOW_V_3_0_PLUS` at the module level
which leads to issues like this
https://github.com/apache/airflow/actions/runs/13135020938/job/36649053953?pr=46375
##########
.pre-commit-config.yaml:
##########
@@ -1229,6 +1229,7 @@ repos:
^providers/tests/ |
^providers/.*/tests/ |
^task_sdk/src/airflow/sdk/definitions/dag.py$ |
+ ^task_sdk/src/airflow/sdk/execution_time/secrets_masker.py$ |
Review Comment:
Ah yeah let me do that
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
