Lee-W commented on code in PR #46375: URL: https://github.com/apache/airflow/pull/46375#discussion_r1942310966
########## newsfragments/46375.significant.rst: ########## @@ -0,0 +1,14 @@ +``SecretsMasker`` has now been moved into the task SDK to be consumed by DAG authors and users + +Any occurrences of the ``secrets_masker`` module will have to be updated from ``airflow.utils.log.secrets_masker`` to the new path: ``airflow.sdk.execution_time.secrets_masker`` + +* Types of change + + * [ ] Dag changes + * [ ] Config changes + * [ ] API changes + * [ ] CLI changes + * [x] Behaviour changes + * [ ] Plugin changes + * [ ] Dependency changes + * [ ] Code interface changes Review Comment: We'll need migration rules for it. Looks like this is path change. We'll need an AIR302 ruff rule. You can follow the example here https://github.com/apache/airflow/blob/699171a6d455cfd66ecc81fd5638129d06317826/newsfragments/41395.significant.rst?plain=1#L23-L33 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
