vincbeck commented on code in PR #46381:
URL: https://github.com/apache/airflow/pull/46381#discussion_r1943539918
##########
providers/tests/amazon/aws/auth_manager/router/test_login.py:
##########
@@ -19,11 +19,16 @@
from unittest.mock import Mock, patch
import pytest
-from flask import session, url_for
-from airflow.exceptions import AirflowException
from airflow.providers.amazon.version_compat import AIRFLOW_V_3_0_PLUS
-from airflow.www import app as application
+
+if not AIRFLOW_V_3_0_PLUS:
+ pytest.skip("AWS auth manager is only compatible with Airflow >= 3.0.0",
allow_module_level=True)
Review Comment:
Only for the AWS auth manager. I introduced some breaking change in the auth
manager interface (core Airflow) that were necessary for AF3. Since AWS auth
manager has been marked as experimental since the beginning, it is easier to
make it compatible only with AF3. Handling both Airflow versions would be a
nightmare. And honestly, I dont think any user uses it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
