ferruzzi commented on code in PR #46381: URL: https://github.com/apache/airflow/pull/46381#discussion_r1943822636
########## providers/src/airflow/providers/amazon/aws/auth_manager/router/login.py: ########## @@ -0,0 +1,124 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +from __future__ import annotations + +import logging +from typing import Any + +import anyio +from fastapi import HTTPException, Request +from starlette import status +from starlette.responses import RedirectResponse + +from airflow.api_fastapi.app import get_auth_manager +from airflow.api_fastapi.common.router import AirflowRouter +from airflow.configuration import conf +from airflow.providers.amazon.aws.auth_manager.constants import CONF_SAML_METADATA_URL_KEY, CONF_SECTION_NAME +from airflow.providers.amazon.aws.auth_manager.user import AwsAuthManagerUser + +try: + from onelogin.saml2.auth import OneLogin_Saml2_Auth + from onelogin.saml2.errors import OneLogin_Saml2_Error + from onelogin.saml2.idp_metadata_parser import OneLogin_Saml2_IdPMetadataParser +except ImportError: + raise ImportError( + "AWS auth manager requires the python3-saml library but it is not installed by default. " + "Please install the python3-saml library by running: " + "pip install apache-airflow-providers-amazon[python3-saml]" Review Comment: Feel free to ignore this since I don't have a good suggestion here, but with the project moving toward using uv to handle packages instead of pip, maybe it's better not to have the exact command? Maybe pulling the version constraint from the constraints and just say "please install python3-saml {constraints}"? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
