Lee-W commented on code in PR #46710:
URL: https://github.com/apache/airflow/pull/46710#discussion_r1953946751
##########
airflow/dag_processing/bundles/git.py:
##########
@@ -68,10 +68,10 @@ def get_ui_field_behaviour(cls) -> dict[str, Any]:
},
}
- def __init__(self, git_conn_id="git_default", *args, **kwargs):
+ def __init__(self, git_conn_id="git_default", repo_url=None, *args,
**kwargs):
Review Comment:
```suggestion
def __init__(self, git_conn_id: str = "git_default", repo_url: str |
None = None, *args, **kwargs) -> None:
```
##########
airflow/dag_processing/bundles/git.py:
##########
@@ -148,8 +148,8 @@ def __init__(
self.git_conn_id = git_conn_id
self.repo_url = repo_url
try:
- self.hook = GitHook(git_conn_id=self.git_conn_id)
- self.repo_url = self.repo_url or self.hook.repo_url
+ self.hook = GitHook(git_conn_id=self.git_conn_id,
repo_url=self.repo_url)
+ self.repo_url = self.hook.repo_url
except AirflowException as e:
Review Comment:
Not related to this PR, but should we make it a more concrete exception
instead of the broad AirflowException 🤔
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
