jedcunningham commented on code in PR #46710:
URL: https://github.com/apache/airflow/pull/46710#discussion_r1953953963
##########
airflow/dag_processing/bundles/git.py:
##########
@@ -148,8 +148,8 @@ def __init__(
self.git_conn_id = git_conn_id
self.repo_url = repo_url
try:
- self.hook = GitHook(git_conn_id=self.git_conn_id)
- self.repo_url = self.repo_url or self.hook.repo_url
+ self.hook = GitHook(git_conn_id=self.git_conn_id,
repo_url=self.repo_url)
+ self.repo_url = self.hook.repo_url
except AirflowException as e:
Review Comment:
Maybe. The most obvious failure mode is missing connection. But I wonder if
there are others... I'll look into this tomorrow, I've taken a note.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
