ashb commented on code in PR #46719:
URL: https://github.com/apache/airflow/pull/46719#discussion_r1954307008
##########
airflow/api_fastapi/execution_api/routes/xcoms.py:
##########
@@ -215,7 +216,8 @@ def set_xcom(
# TODO: This is in-efficient. We json.loads it here for BaseXCom.set to
then json.dump it!
try:
- json.loads(value)
+ # Keep this as long as we do BaseXCom.set(), it serialises again
Review Comment:
Does BaseXCom.set do the serialization itself, or is that handled internally
by SQLA because we are putting it in the an JSON attr? If so then this comment
should be tweaked, as it's not BaseXCom.set that is serializing it again.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
