amoghrajesh commented on code in PR #46719:
URL: https://github.com/apache/airflow/pull/46719#discussion_r1954369523
##########
airflow/api_fastapi/execution_api/routes/xcoms.py:
##########
@@ -215,7 +216,8 @@ def set_xcom(
# TODO: This is in-efficient. We json.loads it here for BaseXCom.set to
then json.dump it!
try:
- json.loads(value)
+ # Keep this as long as we do BaseXCom.set(), it serialises again
Review Comment:
And the sqla doing it again, hence the double one.
So right now, we deser once using `json.loads()` so when 2 sers happen
after, its effectively just one.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
