ashb commented on code in PR #46719:
URL: https://github.com/apache/airflow/pull/46719#discussion_r1957158268
##########
airflow/api_fastapi/execution_api/routes/xcoms.py:
##########
@@ -213,18 +198,6 @@ def set_xcom(
},
)
- # TODO: This is in-efficient. We json.loads it here for BaseXCom.set to
then json.dump it!
- try:
- json.loads(value)
- except json.JSONDecodeError:
- raise HTTPException(
- status_code=status.HTTP_400_BAD_REQUEST,
- detail={
- "reason": "invalid_format",
- "message": "XCom value is not a valid JSON-formatted string",
- },
- )
-
Review Comment:
Yeah, not needed anymore now that the model in the response is JsonValue
itself.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
