eladkal commented on code in PR #46817:
URL: https://github.com/apache/airflow/pull/46817#discussion_r1957850222
##########
providers/apache/spark/src/airflow/providers/apache/spark/hooks/spark_submit.py:
##########
@@ -557,7 +557,7 @@ def submit(self, application: str = "", **kwargs: Any) ->
None:
# Check spark-submit return code. In Kubernetes mode, also check the
value
# of exit code in the log, as it may differ.
- if returncode or (self._is_kubernetes and self._spark_exit_code != 0):
+ if returncode:
Review Comment:
There is a specific comment above this code lines that it require to check
the codes as it may defer.
You did not explain if this is wrong and if so why.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
