uranusjr commented on code in PR #45961:
URL: https://github.com/apache/airflow/pull/45961#discussion_r1962870548


##########
providers/openlineage/tests/unit/openlineage/plugins/test_adapter.py:
##########
@@ -605,9 +606,8 @@ def test_emit_dag_started_event(mock_stats_incr, 
mock_stats_timer, generate_stat
             "dag_id": "dag_id",
             "data_interval_start": event_time.isoformat(),
             "data_interval_end": event_time.isoformat(),
-            "external_trigger": False if AIRFLOW_V_3_0_PLUS else None,
             "run_id": run_id,
-            "run_type": None,
+            "run_type": DagRunType.MANUAL if AIRFLOW_V_3_0_PLUS else None,

Review Comment:
   Does this run_type need to be different from different versions? Especially 
since external_trigger is False, should this always be SCHEDULED instead?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to