uranusjr commented on code in PR #46703:
URL: https://github.com/apache/airflow/pull/46703#discussion_r1962936889


##########
airflow/migrations/versions/0047_3_0_0_add_dag_versioning.py:
##########
@@ -141,7 +141,7 @@ def upgrade():
         batch_op.add_column(sa.Column("created_at", UtcDateTime(), 
nullable=False, default=timezone.utcnow))
 
     with op.batch_alter_table("task_instance", schema=None) as batch_op:
-        batch_op.add_column(sa.Column("dag_version_id", 
UUIDType(binary=False)))
+        batch_op.add_column(sa.Column("dag_version_id", 
UUIDType(binary=False), nullable=False))

Review Comment:
   What happens to old tis created before this column is added? I think we need 
some data migration work here.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to