uranusjr commented on code in PR #46703:
URL: https://github.com/apache/airflow/pull/46703#discussion_r1962939151
##########
airflow/cli/commands/remote_commands/task_command.py:
##########
@@ -211,7 +212,10 @@ def _get_ti(
f"run_id or logical_date of {logical_date_or_run_id!r} not
found"
)
# TODO: Validate map_index is in range?
- ti = TaskInstance(task, run_id=dag_run.run_id, map_index=map_index)
+ dag_version = DagVersion.get_latest_version(dag.dag_id,
session=session)
+ if TYPE_CHECKING:
+ assert dag_version
+ ti = TaskInstance(task, run_id=dag_run.run_id, map_index=map_index,
dag_version_id=dag_version.id)
Review Comment:
Since this pattern is used so often, maybe it’s better for
`get_latest_version` to only return DagVersion and raise an exception if one
cannot be found.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
