ianbuss commented on code in PR #46900:
URL: https://github.com/apache/airflow/pull/46900#discussion_r1963275069
##########
airflow/ui/index.html:
##########
@@ -4,6 +4,7 @@
<meta charset="UTF-8" />
<link rel="icon" type="image/png" href="/pin_32.png" />
Review Comment:
```suggestion
<link rel="icon" type="image/png" href="{{
url_for('webapp_static_folder', path='/pin_32.png') }}" />
```
##########
airflow/ui/index.html:
##########
@@ -4,6 +4,7 @@
<meta charset="UTF-8" />
<link rel="icon" type="image/png" href="/pin_32.png" />
Review Comment:
I think this might help with the bootstrapping of this index page. Ideally
we could also do something like the below for the initial js below but not sure
how that will play with the vite build. We might also be able to set the
`<base>` tag to the hostname + base URL for the relative hrefs here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
