pierrejeambrun commented on code in PR #46900:
URL: https://github.com/apache/airflow/pull/46900#discussion_r1963555252
##########
airflow/ui/index.html:
##########
@@ -4,6 +4,7 @@
<meta charset="UTF-8" />
<link rel="icon" type="image/png" href="/pin_32.png" />
Review Comment:
I'm not sure I get why we want to specifically do something for index links
? Vite build the index as well and we can put whatever we want there. All
static ref will be replaced with the appropriate location. (index is part of
the build) for instance a built index: (`static/assets` is added from the build
step)
```
<html lang="en" style="height: 100%">
<head>
<meta charset="UTF-8" />
<link rel="icon" type="image/png" href="/webapp/pin_32.png" />
<meta name="viewport" content="width=device-width, initial-scale=1.0" />
<meta name="backend-server-base-url" content="{{ backend_server_base_url
}}">
<title>Airflow 3.0</title>
<script type="module" crossorigin
src="/static/assets/index-CDE1oNje.js"></script>
</head>
<body style="height: 100%">
<div id="root" style="height: 100%"></div>
</body>
</html>
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
