ashb commented on code in PR #46933:
URL: https://github.com/apache/airflow/pull/46933#discussion_r1965819344
##########
airflow/ui/vite.config.ts:
##########
@@ -30,7 +30,7 @@ export default defineConfig({
{
name: "transform-url-src",
transformIndexHtml: (html) =>
- html.replace(`src="./assets/`,
`src="./static/assets/`).replace(`href="/`, `href="/webapp/`),
+ html.replace(`src="./assets/`,
`src="./static/assets/`).replace(`href="/`, `href="./`),
Review Comment:
Question: What path does the browser request for when you click a link
directly to a sub-page? i.e. if you navigate to a TI page etc, and then open a
new tab directly at that URL, does the browser see the base as `/webapp/` or
the current url and try to request `/webapp/dag/<dag>/.../static/pin_32.png`?
Maybe not for that file, but other images. that's my concern.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
