ashb commented on code in PR #46933:
URL: https://github.com/apache/airflow/pull/46933#discussion_r1965897647
##########
airflow/ui/src/router.tsx:
##########
@@ -168,4 +168,8 @@ export const routerConfig = [
},
];
-export const router = createBrowserRouter(routerConfig, { basename: "/webapp"
});
+const locationPath = globalThis.window.location.pathname;
+const indexOf = locationPath.indexOf("webapp/");
Review Comment:
Now that we are adding a base tag, is it worth using that instead of the
path based guessing approach? (What we have is probably fine, but we could not
have to guess at all)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
