pierrejeambrun commented on code in PR #46814:
URL: https://github.com/apache/airflow/pull/46814#discussion_r1965990549
##########
tests_common/test_utils/www.py:
##########
@@ -98,7 +100,15 @@ def _check_last_log(session, dag_id, event, logical_date,
expected_extra=None):
assert len(logs) >= 1
assert logs[0].extra
if expected_extra:
+ print(f"json.loads(logs[0].extra) is {json.loads(logs[0].extra)}")
+ print(f"expected_extra is {expected_extra}")
assert json.loads(logs[0].extra) == expected_extra
+ if check_masked:
+ extra_json = json.loads(logs[0].extra)
+ for k, v in extra_json.items():
+ if k in sensitive_fields:
+ assert v == "***", f"Expected masked value for {k}, but got
{v}"
Review Comment:
That will not work for nested fields.
Maybe the easier solution is just to provide the `expected_extra` payload
directly, and don't bother with writting some custom logic for that.
##########
tests_common/test_utils/www.py:
##########
@@ -98,7 +100,15 @@ def _check_last_log(session, dag_id, event, logical_date,
expected_extra=None):
assert len(logs) >= 1
assert logs[0].extra
if expected_extra:
+ print(f"json.loads(logs[0].extra) is {json.loads(logs[0].extra)}")
+ print(f"expected_extra is {expected_extra}")
Review Comment:
I don't think we need those prints.
##########
tests_common/test_utils/www.py:
##########
@@ -76,7 +77,8 @@ def check_content_not_in_response(text, resp, resp_code=200):
assert text not in resp_html
-def _check_last_log(session, dag_id, event, logical_date, expected_extra=None):
+def _check_last_log(session, dag_id, event, logical_date, expected_extra=None,
check_masked=False):
+ sensitive_fields = DEFAULT_SENSITIVE_FIELDS.copy()
Review Comment:
Nit: We are not mutating `sensitive_fields` I don't think we need to make a
copy.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
