vatsrahul1001 commented on code in PR #46814:
URL: https://github.com/apache/airflow/pull/46814#discussion_r1966524674
##########
tests_common/test_utils/www.py:
##########
@@ -98,7 +100,15 @@ def _check_last_log(session, dag_id, event, logical_date,
expected_extra=None):
assert len(logs) >= 1
assert logs[0].extra
if expected_extra:
+ print(f"json.loads(logs[0].extra) is {json.loads(logs[0].extra)}")
+ print(f"expected_extra is {expected_extra}")
assert json.loads(logs[0].extra) == expected_extra
+ if check_masked:
+ extra_json = json.loads(logs[0].extra)
+ for k, v in extra_json.items():
+ if k in sensitive_fields:
+ assert v == "***", f"Expected masked value for {k}, but got
{v}"
Review Comment:
Initially I tried providing `expected_extra`, however, looks like in db
extra column we are adding some additional fields as well due to which
assertion was failing.
##########
tests_common/test_utils/www.py:
##########
@@ -98,7 +100,15 @@ def _check_last_log(session, dag_id, event, logical_date,
expected_extra=None):
assert len(logs) >= 1
assert logs[0].extra
if expected_extra:
+ print(f"json.loads(logs[0].extra) is {json.loads(logs[0].extra)}")
+ print(f"expected_extra is {expected_extra}")
Review Comment:
Resolved
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
