uranusjr commented on code in PR #47008:
URL: https://github.com/apache/airflow/pull/47008#discussion_r1967244932
##########
.pre-commit-config.yaml:
##########
@@ -716,8 +716,8 @@ repos:
- id: check-base-operator-usage
language: pygrep
name: Check BaseOperatorLink core imports
- description: Make sure BaseOperatorLink is imported from
airflow.models.baseoperatorlink in core
- entry: "from airflow\\.models import.* BaseOperatorLink"
+ description: Make sure BaseOperatorLink is imported from
airflow.sdk.definitions.baseoperatorlink in core
+ entry: "from airflow\\.sdk\\.definitions\\.baseoperatorlink import.*
BaseOperatorLink\\b"
Review Comment:
I imagine uses would want to import from `airflow.sdk` instead (via an
alias) so this should be made a bit more permissive.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
