uranusjr commented on code in PR #47008:
URL: https://github.com/apache/airflow/pull/47008#discussion_r1967247023


##########
docs/apache-airflow/howto/define-extra-link.rst:
##########
@@ -31,7 +31,7 @@ The following code shows how to add extra links to an 
operator via Plugins:
 .. code-block:: python
 
     from airflow.models.baseoperator import BaseOperator
-    from airflow.models.baseoperatorlink import BaseOperatorLink
+    from airflow.sdk.definitions.baseoperatorlink import BaseOperatorLink

Review Comment:
   We should probably add an alias and promote `from airflow.sdk import 
BaseOperatorLink` instead.
   
   By the way, should be import to BaseOperator above be changed too?



##########
docs/apache-airflow/howto/define-extra-link.rst:
##########
@@ -31,7 +31,7 @@ The following code shows how to add extra links to an 
operator via Plugins:
 .. code-block:: python
 
     from airflow.models.baseoperator import BaseOperator
-    from airflow.models.baseoperatorlink import BaseOperatorLink
+    from airflow.sdk.definitions.baseoperatorlink import BaseOperatorLink

Review Comment:
   We should probably add an alias and promote `from airflow.sdk import 
BaseOperatorLink` instead.
   
   By the way, should be import to BaseOperator be changed too?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to