ramonvermeulen commented on code in PR #46911:
URL: https://github.com/apache/airflow/pull/46911#discussion_r1967674362
##########
providers/google/src/airflow/providers/google/cloud/operators/cloud_run.py:
##########
@@ -301,6 +306,9 @@ def execute(self, context: Context):
if self.operation is None:
raise AirflowException("Operation is None")
+ if self.expose_logging_url:
+ self.log.info("GCP Console Logging URL: %s ",
self.operation.metadata.log_uri)
Review Comment:
The use-case is that there is a direct link available from within the
Airflow UI/logs, to show the actual cloud run job container logs of that
specific execution. In the issue there was also discussion going on, to have an
implementation that polls the GCP Logging API, to make the logs available line
by line in the Airflow UI. However, there is quite a strict default quota on
the cloud logging API, for me the implementation of just having a direct link
available to the container logs in the GCP console will already help a lot,
therefore I opened this PR.
Depends, but normally when you're already signed in to the GCP console, you
do not need to sign-in again for (I think 24 hours?).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
