sunank200 commented on code in PR #46911:
URL: https://github.com/apache/airflow/pull/46911#discussion_r1967654358
##########
providers/google/src/airflow/providers/google/cloud/operators/cloud_run.py:
##########
@@ -288,6 +292,7 @@ def __init__(
self.polling_period_seconds = polling_period_seconds
self.timeout_seconds = timeout_seconds
self.deferrable = deferrable
+ self.expose_logging_url = expose_logging_url
Review Comment:
```suggestion
self.expose_logging_url = expose_logging_url if expose_logging_url
else False
```
##########
providers/google/src/airflow/providers/google/cloud/operators/cloud_run.py:
##########
@@ -275,6 +278,7 @@ def __init__(
timeout_seconds: float | None = None,
gcp_conn_id: str = "google_cloud_default",
impersonation_chain: str | Sequence[str] | None = None,
+ expose_logging_url: bool = False,
Review Comment:
```suggestion
expose_logging_url: bool | None= False,
```
##########
providers/google/src/airflow/providers/google/cloud/operators/cloud_run.py:
##########
@@ -301,6 +306,9 @@ def execute(self, context: Context):
if self.operation is None:
raise AirflowException("Operation is None")
+ if self.expose_logging_url:
+ self.log.info("GCP Console Logging URL: %s ",
self.operation.metadata.log_uri)
Review Comment:
When this is enabled, do we need to log in to the GCP console only once, or
should we also log in after the job is deferred and completed? What is the use
case here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
