eladkal commented on code in PR #46781:
URL: https://github.com/apache/airflow/pull/46781#discussion_r1970066522
##########
providers/google/src/airflow/providers/google/cloud/operators/dataproc.py:
##########
@@ -2708,6 +2710,25 @@ def
_inject_openlineage_properties_into_dataproc_batch(self, context: Context) -
exc_info=e,
)
+ def __update_batch_labels(self):
+ dag_id = re.sub(r"[.\s]", "_", self.dag_id.lower())
+ task_id = re.sub(r"[.\s]", "_", self.task_id.lower())
Review Comment:
But users can also change dag_id.
Some patterns of dag authoring migrated to use dag_display_name and hide the
option to set dag_id directly.
Unless there is a strong reason to avoid I would rather we allow to set it,
provide to users the needed knowledge and let them to make thier choices.
Regardless if my suggestion is not accepted we should at least explain in a
user facing doc why we don't track the display name.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
