ntr commented on code in PR #46781:
URL: https://github.com/apache/airflow/pull/46781#discussion_r1970377030
##########
providers/google/src/airflow/providers/google/cloud/operators/dataproc.py:
##########
@@ -2708,6 +2710,25 @@ def
_inject_openlineage_properties_into_dataproc_batch(self, context: Context) -
exc_info=e,
)
+ def __update_batch_labels(self):
+ dag_id = re.sub(r"[.\s]", "_", self.dag_id.lower())
+ task_id = re.sub(r"[.\s]", "_", self.task_id.lower())
Review Comment:
I am not sure if `dag_display_name` is a better choice for identifying dags
- I do not see any enforcement for it to be unique. (Updated PR description).
We can just add one more label with display name and make it clear that it
is not id, but to be honest I do not see use-case for that. What do you think?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
