vincbeck commented on PR #47138: URL: https://github.com/apache/airflow/pull/47138#issuecomment-2688770559
No, you are adding a new method to `ResourceMethod` which configures which are the action available in auth managers (I am not talking about FAB auth manager specifically here but auth manager in general). By adding this method then you do `auth_manager.is_authorized_configuration(method=ResourceMethod.PUT) and `auth_manager.is_authorized_configuration(method=ResourceMethod.PATCH) You need to understand that FAB auth manager is not the only auth manager. You are right `get_fab_action_from_method_map` translate `ResourceMethod` to FAB action but again here the issue is, we should not add a new action to the list of actions in `ResourceMethod` which are shared across all auth managers. I think we are on the same page but I think this implementation is wrong. What we want to do is to translate HTTP method `PATCH` to the resource method `ResourceMethod.PUT`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
