pierrejeambrun commented on PR #47138:
URL: https://github.com/apache/airflow/pull/47138#issuecomment-2690252021
Ohhh, yes you are talking about `ResourceMethod = Literal["GET", "POST",
"PUT", "PATCH", "DELETE", "MENU"]`.
I was focusing on `"PATCH": ACTION_CAN_EDIT,`, I understand, yes the
ResourceMethod change is not good.
Then I guess we can do the mapping on the fastapi side. So that `PATCH` will
map to `ResourceMethod.PUT`.
Or don't do anything specific, and we keep things as they were. A patch
endpoint will be decorated with a `@security.requires_access_dag("PUT")`, cf
`patch_dags`. I don't think we need that change at all for now after all.
(Even if I admit this is confusing that every single other HTTP method got
their counterpart `ResourceMethod`, but `PATCH` do not and will use `PUT`, at
first it looks like a mistake, anyway, not needed).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
