jscheffl commented on code in PR #47264:
URL: https://github.com/apache/airflow/pull/47264#discussion_r1977565063
##########
scripts/ci/pre_commit/sync_init_decorator.py:
##########
@@ -119,10 +119,6 @@ def _expr_to_ast_dump(expr: str) -> str:
# Mapping of allowble Decorator type -> Class attribute type
_expr_to_ast_dump("Collection[str] | None"):
_expr_to_ast_dump("MutableSet[str]"),
_expr_to_ast_dump("ParamsDict | dict[str, Any] | None"):
_expr_to_ast_dump("ParamsDict"),
- # TODO: This one is legacy access control. Remove it in 3.0.
RemovedInAirflow3Warning
- _expr_to_ast_dump(
- "dict[str, dict[str, Collection[str]]] | dict[str, Collection[str]] |
None"
- ): _expr_to_ast_dump("dict[str, dict[str, Collection[str]]] | None"),
Review Comment:
@ashb Cleaning this makes static checks fail.
Is there a simple fix or shall I revert this change to make the PR green?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
