pierrejeambrun commented on code in PR #47264:
URL: https://github.com/apache/airflow/pull/47264#discussion_r1980995756
##########
tests/serialization/test_dag_serialization.py:
##########
@@ -981,11 +980,7 @@ def test_dag_params_roundtrip(self, val, expected_val):
assert "params" in serialized_dag["dag"]
if val and any([True for k, v in val.items() if isinstance(v, set)]):
- with pytest.warns(
- RemovedInAirflow3Warning,
- match="The use of non-json-serializable params is deprecated
and will be removed in a future release",
- ):
- deserialized_dag = SerializedDAG.from_dict(serialized_dag)
+ deserialized_dag = SerializedDAG.from_dict(serialized_dag)
Review Comment:
I think the whole `if/else` should be removed. Both code path are the same.
```
deserialized_dag = SerializedDAG.from_dict(serialized_dag)
```
##########
newsfragments/47264.significant.rst:
##########
@@ -0,0 +1,26 @@
+Removed leftover deprecations prior to 3.0.0.
+
+* Removed the ``RemovedInAirflow3Warning`` warning class.
+* Removed the deprecated module ``airflow.api.auth.backend.session``. Please
use ``airflow.providers.fab.auth_manager.api.auth.backend.session`` instead.
+* Removed the deprecated ``cleanup_stuck_queued_tasks`` method from the
``BaseExecutor`` interface. It is replaced by function ``revoke_task``.
+
+* Types of change
+
+ * [ ] Dag changes
+ * [ ] Config changes
+ * [ ] API changes
+ * [ ] CLI changes
+ * [ ] Behaviour changes
+ * [ ] Plugin changes
+ * [ ] Dependency changes
+ * [x] Code interface changes
+
+
+dict[str, dict[str, Collection[str]]]
+None
+
+!=
+
+dict[str, dict[str, Collection[str]]]
+dict[str, Collection[str]]
+None
Review Comment:
Should that be removed ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
